override healthcheck in dockerfile#946
Open
areebahmeddd wants to merge 1 commit into
Open
Conversation
Signed-off-by: Areeb Ahmed <areebahmed0709@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request exposes the model runner port and adds a healthcheck command to the Dockerfile. However, a critical issue was identified where the healthcheck will fail in the final-llamacpp image variant because curl is not installed, which would mark the container as permanently unhealthy. To resolve this, curl must be installed in the llamacpp stage.
ilopezluna
approved these changes
Jun 1, 2026
Contributor
Author
|
ci failure is not related to our changes 🤔 @ilopezluna @ericcurtin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inherit the correct port and /engines/status endpoint for all image variants
fixes #942